fix: used the Timeout instead of two timeoutHeight and timeoutTimestamp #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishal-kanna
requested review from
AdityaSripal,
charleenfei,
colin-axner,
damiannolan,
crodriguezvega,
chatton and
DimitrisJim
as code owners
vishal-kanna
changed the title
charleenfei
reviewed
Jun 6, 2023
| @@ -431,7 +431,7 @@ func (endpoint *Endpoint) SendPacket( | |||
| channelCap := endpoint.Chain.GetChannelCapability(endpoint.ChannelConfig.PortID, endpoint.ChannelID) | |||
There was a problem hiding this comment.
I think you can also update the SendPacket api on this endpoint :)
charleenfei
reviewed
Jun 6, 2023
charleenfei
reviewed
Jun 6, 2023
9 tasks
|
@vishal-kanna, thank you very much for opening this PR. However, we discussed this internally and as @colin-axner explains in his comment, it might be better to hold on implementing this change for now since it will break IBC applications. So I hope you don't mint, but I will close the PR now. Again, thank you very much for taking the initiative to implement this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3727
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.